-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix node 18 breakage #176
fix node 18 breakage #176
Conversation
why is it a fatal operation? |
i believe it's due to nodejs/node#40696 adding them to the official API |
According to the documentation the read-only property called "closed" was added to the Writable class in v18.0.0 of nodejs. And it also looks like the property "_closed" is used internally in the SMTPConnection class. So this patch looks ok. |
Thanks for the patch. May I ask, when will the new version be published ? |
The test suite coverage is very low, so removing |
@andris9 it is now a conditional set, achieved by consulting a new getter-only prop on ...of course, since it's a (likely tiny) perf hit, i'll stew on it for years until v16 goes EOL & i can re-submit the original changeset 😆 |
thanks! |
setting the
closed
property is a fatal operation under node 18. removing the offending lines seems to make no difference for the tests. i've added a github actions workflow for running the tests under various nodes & fixed a test that was failing under windows.