Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag-major.yml #23

Merged
merged 2 commits into from
May 29, 2024
Merged

Update tag-major.yml #23

merged 2 commits into from
May 29, 2024

Conversation

jasonkarns
Copy link
Member

@jasonkarns jasonkarns commented May 29, 2024

Switch to pushing lightweight tags instead of branches as vN

closes #20

Switch to pushing lightweight tags instead of branches as vN
@jasonkarns jasonkarns merged commit 85ab3c3 into main May 29, 2024
@jasonkarns jasonkarns deleted the tag-major branch May 29, 2024 22:04
jasonkarns added a commit that referenced this pull request Jun 2, 2024
jasonkarns added a commit that referenced this pull request Jun 2, 2024
This reverts commit 85ab3c3.

GitHub Releases are essentially broken when trying to autogenerate notes
from the most recent tag. (It grabs the vN tag even though it's a
lightweight tag that is not "permanent". Thanks to github's recommended
workflow/actions process.)

Additionally, it messes with local development because tags won't
overwrite by default.
jasonkarns added a commit that referenced this pull request Jun 2, 2024
This reverts commit 85ab3c3.

GitHub Releases are essentially broken when trying to autogenerate notes
from the most recent tag. (It grabs the vN tag even though it's a
lightweight tag that is not "permanent". Thanks to github's recommended
workflow/actions process.)

Additionally, it messes with local development because tags won't
overwrite by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch tag-major workflow to push a tag instead of a branch
1 participant