Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nsp check from prepare to optional script #77

Closed
lance opened this issue Feb 20, 2018 · 0 comments · Fixed by #78
Closed

Move nsp check from prepare to optional script #77

lance opened this issue Feb 20, 2018 · 0 comments · Fixed by #78
Assignees
@lholmquist
Labels
enhancement

Comments

@lance
Copy link

lance commented Feb 20, 2018

Instead, we should just echo a message in prepare. E.g.

"prepare": "echo 'To confirm CSV compliance, run 'npm run security-check'",
"security-check: nsp check"

or something...
lholmquist added a commit to lholmquist/nodejs-rest-http-crud that referenced this issue Feb 20, 2018
@lholmquist
feat(package): Move nsp check from prepare step to an optional script.
bdc8e15 
* prepare will now output a message telling the user how to run nsp.

fixes nodeshift-starters#77
@lholmquist lholmquist mentioned this issue Feb 20, 2018
Merged
@ghost ghost added the in progress label Feb 20, 2018
lholmquist added a commit that referenced this issue Feb 20, 2018
@lholmquist
feat(package): Move nsp check from prepare step to an optional script. (
914a763 
#78)

* prepare will now output a message telling the user how to run nsp.

fixes #77
@ghost ghost removed the in progress label Feb 20, 2018
@snyk-bot snyk-bot mentioned this issue Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lholmquist lholmquist

Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@lance @lholmquist