Adding typescript typings plugin #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helio-frota
approved these changes
Aug 3, 2021
|
@richardlau are you okay with me merging this one ?? |
richardlau
approved these changes
Aug 4, 2021
LGTM. Go for it 🙂. |
aalykiot
added a commit
that referenced
this pull request
Aug 5, 2021
* TypeError when GitHub URL is not defined #52 * TypeError when GitHub URL is not defined #52 * feat: adding typescript typings plugin (#51) * chore: use coveralls action (#55) Use the Coveralls GitHub action instead of the module to allow coverage runs on pull requests from forks. Fixes: #54 * TypeError when GitHub URL is not defined #52 * Rebase with main #52 * TypeError when GitHub URL is not defined #52 * TypeError when GitHub URL is not defined #52 Co-authored-by: Zubin Bhasin <zubin.bhasin@freecharge.com> Co-authored-by: Alex Alikiotis <alexalikiotis5@gmail.com> Co-authored-by: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #48