Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using the coveralls GitHub action #54

Closed
aalykiot opened this issue Aug 4, 2021 · 0 comments · Fixed by #55
Closed

Switch to using the coveralls GitHub action #54

aalykiot opened this issue Aug 4, 2021 · 0 comments · Fixed by #55

Comments

@aalykiot
Copy link
Member

aalykiot commented Aug 4, 2021

Since using the coveralls npm module breaks the CI on PRs coming from forks:

/home/runner/work/npcheck/npcheck/node_modules/coveralls/bin/coveralls.js:19
      throw err;
      ^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}
(Use `node --trace-uncaught ...` to show where the exception was thrown)
Error: Process completed with exit code 1.

It would be great if we move the coveralls checks on the CI layer.

@richardlau @helio-frota if any of you have time to take this one would be great since my CI knowledge is limited.
@richardlau richardlau mentioned this issue Aug 4, 2021
Merged
richardlau added a commit that referenced this issue Aug 4, 2021
@richardlau
chore: use coveralls action (#55)
ff62ce2 
Use the Coveralls GitHub action instead of the module to allow
coverage runs on pull requests from forks.

Fixes: #54
aalykiot added a commit that referenced this issue Aug 5, 2021
@zubinbhasin @aalykiot @richardlau
TypeError when GitHub URL is not defined (#53)
0bfd8c4 
* TypeError when GitHub URL is not defined #52

* TypeError when GitHub URL is not defined #52

* feat: adding typescript typings plugin (#51)

* chore: use coveralls action (#55)

Use the Coveralls GitHub action instead of the module to allow
coverage runs on pull requests from forks.

Fixes: #54

* TypeError when GitHub URL is not defined #52

* Rebase with main #52

* TypeError when GitHub URL is not defined #52

* TypeError when GitHub URL is not defined #52

Co-authored-by: Zubin Bhasin <zubin.bhasin@freecharge.com>
Co-authored-by: Alex Alikiotis <alexalikiotis5@gmail.com>
Co-authored-by: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use coveralls action nodeshift/npcheck
1 participant
@aalykiot