TypeError when GitHub URL is not defined #52

src/plugins/archive.js

@@ -1,18 +1,24 @@
-const { createError } = require('../lib/result');
-const { stringBuilder, success, failure } = require('../lib/format');
+const { createError, createWarning } = require('../lib/result');
+const { stringBuilder, success, failure, warning } = require('../lib/format');
 const { fetchGithub } = require('../lib/fetch');
 
 const archivePlugin = async (pkg, _, options) => {
+
+  const output = stringBuilder(
+    'Checking if github repository is archived'
+  ).withPadding(65);
+
+  if (!pkg?.repository?.url) {
+    warning(output.get());
+    return createWarning(`The module "${pkg.name}" does not specify its GitHub repository.`);
+  }
+
   const githubTarget = pkg.repository.url
     .split('github.com/')[1]
     .replace('.git', '');
 
   const repo = await fetchGithub(`/repos/${githubTarget}`, options.githubToken);
 
-  const output = stringBuilder(
-    'Checking if github repository is archived'
-  ).withPadding(65);
-
   if (repo.deprecated) {
     failure(output.get());
     return createError(

test/plugins/archive.test.js

@@ -8,7 +8,8 @@ jest.mock('../../src/lib/fetch');
 jest.mock('../../src/lib/format', () => ({
   ...jest.requireActual('../../src/lib/format'),
   failure: jest.fn(),
-  success: jest.fn()
+  success: jest.fn(),
+  warning: jest.fn()
 }));
 
 afterEach(() => {
@@ -95,3 +96,25 @@ it('should log failure message when module is archived', async () => {
 
   expect(format.failure).toHaveBeenCalled();
 });
+
+it('should log warning message when module does not specify its GitHub repository url', async () => {
+
+  const pkg = {
+    repository: {
+    }
+  };
+
+  const result = await archivePlugin(pkg, null, {});
+
+  expect(result.type).toBe('warning');
+  expect(format.warning).toHaveBeenCalled();
+});
+
+it('should log warning message when module does not specify its GitHub repository', async () => {
+
+  const pkg = {};
+  const result = await archivePlugin(pkg, null, {});
+
+  expect(result.type).toBe('warning');
+  expect(format.warning).toHaveBeenCalled();
+});