-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the config-loader again #54
Comments
This will change the method signature from if you still want to pass in a custom config object, add it to also going to raise the node version needed to 8.x Once this change is in, we will probably bump to 1.0.0 since it is a breaking change |
@tavogel wanted to give you a heads up |
* It is no longer necessary to include the openshift-config-loader separate. By default, just calling the rest client will do the default config loading. If a user needs to pass a config into the client, use the settings object. ex: settings.config = {...} This is a breaking change from the previous version fixes nodeshift#54
Thanks. This will be breaking as we don't use local configuration but as long as we can still override it should be ok |
@tavogel yea, you can override using |
@tavogel if you wanted to give the new version a try, i created a "canary" version as 0.12.0-0 |
After talking with @lance, we decided it might be better to have the config loader integrated back into this library.
I think if no config is passed, then it just does the default stuff(calls config-loader), but if a config is passed in, then it will use that instead
I think i was trying to be to smart with this #5
The text was updated successfully, but these errors were encountered: