Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security vulnerability #56

Closed
lholmquist opened this issue Feb 15, 2018 · 0 comments · Fixed by #57
Closed

security vulnerability #56

lholmquist opened this issue Feb 15, 2018 · 0 comments · Fixed by #57
Assignees

Comments

@lholmquist
Copy link
Member

lholmquist commented Feb 15, 2018

openshift-rest-client@1.0.0 > request@2.83.0 > hawk@6.0.2 > hoek@4.2.0

the ideal thing would be to update request, looks like there is already an issue request/request#2874

which is dependant on hawk - mozilla/hawk#234

looks like the hoek update there 4.x branch to fix it https://github.com/hapijs/hoek/releases/tag/v4.2.1

we can include hoek@4.2.1 as a dependency, which will fix the issue, or we can wait a day or 2 for request to fix itself

lholmquist added a commit to lholmquist/openshift-rest-client that referenced this issue Feb 15, 2018
…ps://nodesecurity.io/advisories/566

this eventually should come out, and we should update request instead, but at the time of this commit, a fix was not published yet

fixes nodeshift#56
@ghost ghost assigned lholmquist Feb 15, 2018
@ghost ghost added the in progress label Feb 15, 2018
lholmquist added a commit that referenced this issue Feb 19, 2018
…sue - https://nodesecurity.io/advisories/566 (#57)

this eventually should come out, and we should update request instead, but at the time of this commit, a fix was not published yet

fixes #56
@ghost ghost removed the in progress label Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant