Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load config from a file location. #190

Merged
merged 2 commits into from
Jan 21, 2020
Merged

feat: load config from a file location. #190

merged 2 commits into from
Jan 21, 2020

Conversation

lholmquist
Copy link
Member

This adds the ability to pass in a string value for settings.config, which points to the location of a kubernetes/optionshift config

fixes #189

@lholmquist
feat: load config from a file location.
2820a69 
This adds the ability to pass in a string value for `settings.config`, which points to the location of a kubernetes/optionshift config

fixes nodeshift#189
@coveralls
Copy link

coveralls commented Jan 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 601

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 599: 0.0%
Covered Lines: 65
Relevant Lines: 65
💛 - Coveralls

@lholmquist lholmquist merged commit 811a67f into nodeshift:master Jan 21, 2020
@lance lance mentioned this pull request May 11, 2022
Closed
@lholmquist lholmquist mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helio-frota helio-frota helio-frota approved these changes

@aalykiot aalykiot aalykiot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass in a kubernetes config location to load
4 participants
@lholmquist @coveralls @helio-frota @aalykiot