Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use rejectUnauthorzed instead of strictSSL #401

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: Use rejectUnauthorzed instead of strictSSL #401

merged 1 commit into from
Apr 23, 2024

Conversation

lholmquist
Copy link
Member

Even though they should be the same thing, strictSSL was not working but rejectUnauthorized does.

frrom #390 but with added tests

@Megapixel99 @lholmquist
fix: Use rejectUnauthorzed instead of strictSSL
34fd1d3 
Even though they should be the same thing, `strictSSL` was not working but `rejectUnauthorized` does.
@coveralls
Copy link

Coverage Status

coverage: 98.802%. remained the same
when pulling 34fd1d3 on lholmquist:rejectUnathorizedWithTests
into 271304a on nodeshift:main.

@lholmquist lholmquist merged commit d5722b5 into nodeshift:main Apr 23, 2024
5 checks passed
@lholmquist lholmquist deleted the rejectUnathorizedWithTests branch April 23, 2024 17:39
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
@lholmquist lholmquist mentioned this pull request Apr 23, 2024
Closed
@lholmquist lholmquist mentioned this pull request Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lholmquist @coveralls @Megapixel99