Add StatefulSet resource #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tremes
commented
Nov 1, 2018
| t.end(); | ||
| }).catch(e => { | ||
| console.log(e); | ||
| }); |
There was a problem hiding this comment.
I can remove this catch once the tests will be passing
lholmquist
reviewed
Nov 12, 2018
test/statefulset-test.js
Outdated
|
|
||
| nock(clientConfig.cluster) | ||
| .matchHeader('authorization', `Bearer ${clientConfig.user.token}`) // taken from the config | ||
| .get(`/oapi/v1/namespaces/${clientConfig.context.namespace}/statefulsets/${statefulSetName}`) |
There was a problem hiding this comment.
This should be /apis/apps/v1beta1 instead of /oapi/v1/
There was a problem hiding this comment.
Oh yes...stupid mistake:). Thanks
lholmquist
reviewed
Nov 12, 2018
test/statefulset-test.js
Outdated
|
|
||
| nock(clientConfig.cluster) | ||
| .matchHeader('authorization', `Bearer ${clientConfig.user.token}`) // taken from the config | ||
| .post(`/oapi/v1/namespaces/${clientConfig.context.namespace}/statefulsets`) |
There was a problem hiding this comment.
This should be /apis/apps/v1beta1 instead of /oapi/v1/
lholmquist
reviewed
Nov 12, 2018
test/statefulset-test.js
Outdated
| test('find - statefulsets - find - no statefulset name', (t) => { | ||
| openshiftRestClient(settings).then((client) => { | ||
| client.statefulsets.find().catch((err) => { | ||
| t.equal(err.message, 'StatefulSet Name is required', 'error message should return'); |
There was a problem hiding this comment.
Tests fail because it is looking for Stateful Set
There was a problem hiding this comment.
Again...stupid mistake:) Thanks a lot for review. I am about to push an update.
tremes
force-pushed
the
statefulset_resources
branch
from
bc6e85b
to
4064ea5
Compare
Pull Request Test Coverage Report for Build 279
💛 - Coveralls |
|
@lholmquist Yeah sure. |
tremes
force-pushed
the
statefulset_resources
branch
from
4064ea5
to
fc75bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.