Use options object for all configuration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try and option to expose performance metrics
lholmquist
reviewed
Apr 16, 2020
README.md
Outdated
| |Name |Description |Default | | ||
| |--------------------------|------------------------------------------------------------------------|--------------| | ||
| |`circuits` |A list or individual circuit breaker to create metrics for |No circuits | | ||
| |`registry` |An existing registry to use for prometheus metrics |A new registry| |
There was a problem hiding this comment.
i think the default here is undefined, or something like that
There was a problem hiding this comment.
I have added some more information about this option
lholmquist
reviewed
Apr 16, 2020
README.md
Outdated
| ``` | ||
|
|
||
| ## Options | ||
| The second argument of the `PrometheusMetrics` constructor is an options object. |
There was a problem hiding this comment.
no longer the second argument
There was a problem hiding this comment.
Thanks I have corrected this
lholmquist
approved these changes
Apr 20, 2020
lholmquist
requested changes
Apr 20, 2020
|
How does this look now? Should I close #18 and I can raise another MR once this is in master? |
lholmquist
requested changes
Apr 21, 2020
index.js
Outdated
| registers: [this._registry], | ||
| labelNames: ['name', 'event'] | ||
| }); | ||
| if (this.exposePerformanceMetrics()) { |
There was a problem hiding this comment.
I think this should be in the next PR instead of this one
index.js
Outdated
| } | ||
| } | ||
|
|
||
| exposePerformanceMetrics () { |
There was a problem hiding this comment.
same as the previous comment
index.js
Outdated
| @@ -55,7 +59,8 @@ class PrometheusMetrics { | |||
| this._counter.labels(circuit.name, eventName).inc(); | |||
| }); | |||
|
|
|||
| if (eventName === 'success' || eventName === 'failure') { | |||
| if (this.exposePerformanceMetrics() && | |||
There was a problem hiding this comment.
same as the previous comment
|
@HarryEMartland thanks for keeping up with this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.