Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a circuit's stats rolling #32

Closed
lance opened this issue Mar 7, 2017 · 1 comment
Closed

Make a circuit's stats rolling #32

lance opened this issue Mar 7, 2017 · 1 comment
Assignees
@lance @lholmquist
Labels
enhancement

Comments

@lance
Copy link
Member

lance commented Mar 7, 2017

When generating stats for the Hystrix dashboard, much of them are rolling numbers that reset after a configurable amount of time. This makes sense because if you're monitoring an application's performance, you probably don't care about the 5000 failures that happened yesterday, because you fixed that problem already with a hotfix - but if your stats aren't rolling, then you'll keep seeing that 5000 failure number until the app with the circuit is restarted
@lance lance self-assigned this Mar 7, 2017
lance added a commit that referenced this issue Mar 8, 2017
@lance
feat: add basic rolling stats to a circuit
8fb9561 
This replaces the existing cumulative behavior of a circuit's status, in
favor of snapshots every `X` milliseconds, where `X` defaults to 10000,
e.g. 10 seconds. This allows for rolling average calculations on
important statistics for Hystrix dashboard, and is in pursuit of
#32 (but does not
complete it).
@lance
Copy link
Member Author

lance commented Apr 3, 2017

Completed in 05c0a2f

@lance lance closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance lance

@lholmquist lholmquist

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lance @lholmquist