Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use pull_request_target in actions workflow #476

Merged
merged 1 commit into from
Oct 26, 2020
Merged

build: use pull_request_target in actions workflow #476

merged 1 commit into from
Oct 26, 2020

Conversation

richardlau
Copy link
Contributor

Coverage uploads require access to a repository secret, which isn't
accessible to pull requests from forks with the pull_request event.

Refs: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks

@richardlau
build: use pull_request_target in actions workflow
2369256 
Coverage uploads require access to a repository secret, which isn't
accessible to pull requests from forks with the `pull_request` event.

Refs: https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks
@helio-frota
Copy link
Member

I saw here it seems working fine https://coveralls.io/github/nodeshift/opossum?branch=actionstest

@helio-frota
Copy link
Member

@richardlau Oh I think I got it, this PR is the actual fix but the other WIP PR is the one that updated the coveralls right ?

@richardlau
Copy link
Contributor Author

@richardlau Oh I think I got it, this PR is the actual fix but the other WIP PR is the one that updated the coveralls right ?

I think https://coveralls.io/github/nodeshift/opossum?branch=actionstest is from when I pushed to the actionstest branch for this PR. TBH I'm not sure where the coverage for the WIP PR went as I don't see in the coveralls UI anything for pull requests 😅. https://github.com/nodeshift/opossum/actions/runs/328970228 (actions run for the WIP PR) did pass though, while it didn't for an earlier run when the actionstest branch had not been updated to use pull_request_target (https://github.com/nodeshift/opossum/actions/runs/328964515).

@richardlau richardlau merged commit 814cd4f into master Oct 26, 2020
@richardlau richardlau deleted the actionstest branch October 26, 2020 15:10
@helio-frota
Copy link
Member

@richardlau thank you 👍

@richardlau richardlau mentioned this pull request Oct 26, 2020
Merged
richardlau added a commit that referenced this pull request Nov 24, 2020
@richardlau
Revert "build: use pull_request_target in actions workflow (#476)"
aaaca9c 
This reverts commit 814cd4f.
richardlau added a commit that referenced this pull request Nov 24, 2020
@richardlau
Revert "build: use pull_request_target in actions workflow (#476)"
3fa32b9 
This reverts commit 814cd4f.
This was referenced Nov 24, 2020
Merged
Open
@github-actions github-actions bot mentioned this pull request Dec 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helio-frota helio-frota helio-frota approved these changes

Assignees

@richardlau richardlau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardlau @helio-frota