-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node 15 support #473
Add Node 15 support #473
Conversation
Why failed on Node 10 and 12... |
looks like it is failing when trying to publish the coverage report to coveralls |
@hongbo-miao @lholmquist this may be config, I can take a look on that later #474 |
@helio-frota The failure is going to be because the PR came from a fork and those can't access secrets (being used to provide the token for coverage). We may be able to change the workflow to use the |
I've rebased this after landing #476 on master and we now have a passing CI 🎉. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hongbo-miao
You are welcome : ) |
@richardlau @lholmquist Could you release this implementation in a version please? Many thanks! |
No description provided.