Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 15 support #473

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Add Node 15 support #473

merged 2 commits into from
Oct 26, 2020

Conversation

hongbo-miao
Copy link
Contributor

No description provided.

@hongbo-miao
Copy link
Contributor Author

Why failed on Node 10 and 12...

@lholmquist
Copy link
Member

looks like it is failing when trying to publish the coverage report to coveralls

@helio-frota
Copy link
Member

that seems flakey issue with coveralls.

this is the latest working :

2020-10-23_22-19

@helio-frota helio-frota mentioned this pull request Oct 24, 2020
@helio-frota
Copy link
Member

@hongbo-miao @lholmquist this may be config, I can take a look on that later #474

@richardlau
Copy link
Contributor

@hongbo-miao @lholmquist this may be config, I can take a look on that later #474

@helio-frota The failure is going to be because the PR came from a fork and those can't access secrets (being used to provide the token for coverage). We may be able to change the workflow to use the pull_request_target instead of pull_request event, see https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks.

@richardlau
Copy link
Contributor

I've rebased this after landing #476 on master and we now have a passing CI 🎉.

Copy link
Member

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hongbo-miao

@lholmquist lholmquist merged commit b30c45d into nodeshift:master Oct 26, 2020
@hongbo-miao hongbo-miao deleted the patch-2 branch October 26, 2020 17:48
@hongbo-miao
Copy link
Contributor Author

You are welcome : )

@ale-grosselle
Copy link

ale-grosselle commented Nov 3, 2020

@richardlau @lholmquist Could you release this implementation in a version please?

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants