Additional param in errorFilter option

[vizhukova]

Hello, opossum team!

I've got a question about expansion errorFilter functionality.
Initial data:
The breaker once defined in the project and reused by every request
I need to ignore errors only for one request (as it is expected behavior and I need to call query until it response success)
So I expect something like that

const breaker = new CircuitBreaker(asyncFunction, {
      name,
      timeout,
      resetTimeout,
      errorFilter: (err, query) => {
       if(err.code === 'SOME_ERROR_CODE' && query === 'some')
     },
    })

Is it possible to add another one query param to the errorFilter?

Thanks in advance,
Veronika

[lance]

Hi @vizhukova it's not clear what you expect query to be in this case. Would it work to pass the parameters originally provided to the failing asyncFunction? Specifically here in handleError:

opossum/lib/circuit.js

Lines 648 to 655 in 32762f4

	function handleError (error, circuit, timeout, args, latency, resolve, reject) {
	clearTimeout(timeout);
	if (circuit.options.errorFilter(error)) {
	circuit.emit('success', error, latency);
	} else {
	fail(circuit, error, args, latency);
	}

If line 651 looked instead like

  if (circuit.options.errorFilter(error, args)) {

Would this solve the problem?

[vizhukova]

Yeah! This will help