Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint issues in test #499

Merged
merged 1 commit into from
Nov 24, 2020
Merged

fix: lint issues in test #499

merged 1 commit into from
Nov 24, 2020

Conversation

helio-frota
Copy link
Member

No description provided.

@helio-frota
Copy link
Member Author

helio-frota commented Nov 23, 2020

it looks like cache or something.
I sent the PR to fix the 2 lint issues and standard still showing previous error messages.

standardx: Run `standardx --fix` to automatically fix some problems.
  /home/runner/work/opossum/opossum/test/error-filter-test.js:12:17: Unexpected parentheses around single function argument.
  /home/runner/work/opossum/opossum/test/error-filter-test.js:74:14: Missing semicolon.

@richardlau
Copy link
Contributor

it looks like cache or something.
I sent the PR to fix the 2 lint issues and standard still showing previous error messages.

standardx: Run `standardx --fix` to automatically fix some problems.
  /home/runner/work/opossum/opossum/test/error-filter-test.js:12:17: Unexpected parentheses around single function argument.
  /home/runner/work/opossum/opossum/test/error-filter-test.js:74:14: Missing semicolon.

Looking at https://github.com/nodeshift/opossum/pull/499/checks?check_run_id=1441642156#step:2:211 the checkout action checked out 03fed29, which is the current HEAD of the master branch and not fix-lint. This may be because the trigger is pull_request_target, which we switched to on my recommendation to allow code coverage for PR's from forks. Perhaps I've misunderstood how pull_request_target works. I'll do some more research.

@helio-frota
Copy link
Member Author

@richardlau thank you for the clarification. Please let me know if it is better for me to close this PR or something 👍

@richardlau richardlau mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants