Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix markdown linter for release changelogs #47

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

juanarbol
Copy link
Contributor

This, besides fixing the md linter (add <!--lint disable maximum-line-length no-literal-urls prohibited-strings--> as Node.js does), proposes following the changelog file structure adopted by Node.js core, it separates each release line instead of having a single changelog file for all release lines.

Copy link
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Shouldn't we create a PR first for 18.x so we can add the link to 18.x in the 20.x changelog though?

Copy link
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be updated to 5.0.4?

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@juanarbol juanarbol merged commit 39eb0ec into node-v20.x-nsolid-v5.x Feb 12, 2024
11 of 12 checks passed
juanarbol added a commit that referenced this pull request Feb 12, 2024
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #47
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris pushed a commit that referenced this pull request Feb 28, 2024
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #47
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants