-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #175, handle trailing slash on endpoint #176
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Jason Nguyen <jason-nguyen@pluralsight.com> Co-authored-by: Bret Hubbard <bret-hubbard@pluralsight.com
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 146 147 +1
Branches 37 37
=========================================
+ Hits 146 147 +1
Continue to review full report at Codecov.
|
Hello @kr1sp1n ! We're not sure why 1 of the checks didn't complete on this PR. Can you provide any context on this? |
fixes nodevault#175 Co-authored-by: Jason Nguyen <jason-nguyen@pluralsight.com> Co-authored-by: Bret Hubbard <bret-hubbard@pluralsight.com
based on nodevault#176 fixes nodevault#175 Co-authored-by: Jason Nguyen <jason-nguyen@pluralsight.com> Co-authored-by: Bret Hubbard <bret-hubbard@pluralsight.com
@wes-novack do you mind updating the base branch? (can't do it via the UI here) |
I no longer have access to the repo. @GoFightNguyen can you help here? |
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 146 147 +1
Branches 37 37
=========================================
+ Hits 146 147 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
No description provided.