Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fbpspec #679

Merged
merged 5 commits into from
Feb 20, 2017
Merged

Fix fbpspec #679

merged 5 commits into from
Feb 20, 2017

Conversation

jonnor
Copy link
Member

@jonnor jonnor commented Feb 19, 2017

Fixes #587

Is required in Polymer element where it doesnt get replaced by WebPack
Fixes schema load error, all dependencies updated
@jonnor
Copy link
Member Author

jonnor commented Feb 19, 2017

Example for a failing tests,
flowhub-fbpspec-failingtest

@jonnor jonnor requested a review from bergie February 19, 2017 23:09
@jonnor
Copy link
Member Author

jonnor commented Feb 19, 2017

No idea why VersionEye now complains, nothing has changed wrt to license of fbp-spec...

@bergie
Copy link
Member

bergie commented Feb 20, 2017

@jonnor VersionEye has this bug where occasionally they fail when they see a new dependency they haven't fetched yet

"sinon": "^1.17.7",
"syn": "0.2.2",
"yaml-include-loader": "^1.0.0"
},
"scripts": {
"test": "grunt test"
"test": "grunt test",
"start": "./node_modules/.bin/simple-server . 9999"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a convenient change. Should be mentioned in the README

@bergie
Copy link
Member

bergie commented Feb 20, 2017

@jonnor please mention npm start in README and the bug fix in CHANGES

@bergie bergie merged commit 1e328c4 into master Feb 20, 2017
@bergie bergie deleted the fix-fbpspec branch February 20, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants