This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #198
Description
Add VerifyProof variant to BlackBoxFunc enum
Summary of changes
This will be used by backends looking to integrate recursion. As per the issue discussion, this requires enabling the OutputSize of FuncDefinition's to be Variable. I left the
InputSize
andOutputSize
enums distinct for now and left a comment under what scenarios OutputSize can be Variable. The OutputSize is NOT dependent upon the user inputs (like the input size to sha256 for example), but rather dependent upon the proving system that is integrating with ACVM. This distinction is important as this change to variable output size does imply support for dynamic circuits.I will make an issue to consider how we can best differentiate whether the variable OutputSize can be dependent upon a gadget's input. It might need to be in this PR though where we have a function in the ProofSystemCompiler similar to
black_box_function_supported
that can output a BlackBoxFunc's proof system dependent OutputSize. Opening this PR as part of the discussion.Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)