This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm)!: expose backend identifier on ProofSystemCompiler trait
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
reviewed
May 16, 2023
acvm/src/lib.rs
Outdated
| @@ -207,6 +207,9 @@ pub trait ProofSystemCompiler { | |||
| /// The Error type returned by failed function calls in the ProofSystemCompiler trait. | |||
| type Error: std::error::Error; // fully-qualified named because thiserror is `use`d at the top of the crate | |||
|
|
|||
| /// Returns the identifier for the backend. | |||
| fn backend_identifier(&self) -> String; | |||
There was a problem hiding this comment.
This is also needed by code that calls the CommonReferenceString trait, so do we want it to be on the Backend trait itself or a separate trait that others can depend upon?
There was a problem hiding this comment.
Hmm, I don't really want to put this on Backend as that would hamper our ability to pass &impl SubTraits around effectively.
I placed it on ProofSystemCompiler as this is the trait which is most tightly bound to the underlying proving library. PWG/SmartContract shouldn't ever need to expose this information so we could have a separate trait which is just ProofSystemCompiler and CommonReferenceString depend on.
|
This trait is being removed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #196
Description
Summary of changes
This PR exposes the
backend_identifermethod onProofSystemCompilerwhich returns a string identifier for the backend.I'm doing an initial pass through the repos to just include the name of the backend. We can add extra info later on before merging.
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)