This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
fix: solvable intermediate gates for csat #433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
reviewed
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Will do a full review next week.
guipublic
changed the title
fix: solvable intermediate gates for csat *DO NOT MERGE*
fix: solvable intermediate gates for csat
Jul 13, 2023
5 tasks
TomAFrench
reviewed
Jul 17, 2023
I thought a bit more about this and decided that we should instead track the private inputs to the circuit rather than the full set of witnesses required to start execution. We can then calculate this from private+public parameters. |
TomAFrench
force-pushed
the
linear-acvm
branch
5 times, most recently
from
July 17, 2023 10:59
bed1a93
to
ffe361c
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
The width reduction creates intermediate variables from an expression. However, if an unknown variable is used for the intermediate one, from the expression, the intermediate is also unknown. In that case the csat generates an arithmetic gate with 2 unknowns and it cannot be resolved in one step.
Resolves
Summary*
We only use 'known' witnesses when generating intermediate variables.
To do this, we track the 'known' witness in a map, after each opcode that the transformation pass processes.
Additional Context
PR Checklist*
cargo fmt
on default settings.