This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
chore(acir)!: Remove Block, RAM and ROM opcodes
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
reviewed
Jul 26, 2023
TomAFrench
commented
Jul 26, 2023
kevaundray
approved these changes
Jul 26, 2023
TomAFrench
changed the title
Block, RAM and ROM opcodes
|
LGTM - one nit, would be good to move the doc comment about init to MemInit. ie:
|
2 tasks
TomAFrench
changed the title
Block, RAM and ROM opcodesBlock, RAM and ROM opcodes
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR removes the
Block,RAMandROMopcodes, we have replaced these opcodes withMemOpandMemInit. It also renames some concepts which no longer make sense without them.Additional Context
PR Checklist*
cargo fmton default settings.