chore: add check that comparison is against zero

noir-lang · Aug 8, 2023 · 067b621 · 067b621
1 parent 8206828
commit 067b621
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/crates/noirc_evaluator/src/ssa/ir/instruction.rs b/crates/noirc_evaluator/src/ssa/ir/instruction.rs
@@ -594,9 +594,11 @@ impl Binary {
                     return SimplifyResult::SimplifiedTo(zero);
                 }
                 if let Type::Numeric(NumericType::Unsigned { .. }) = operand_type {
-                    // Unsigned values cannot be less than zero.
-                    let zero = dfg.make_constant(FieldElement::zero(), Type::bool());
-                    return SimplifyResult::SimplifiedTo(zero);
+                    if rhs_is_zero {
+                        // Unsigned values cannot be less than zero.
+                        let zero = dfg.make_constant(FieldElement::zero(), Type::bool());
+                        return SimplifyResult::SimplifiedTo(zero);
+                    }
                 }
             }
             BinaryOp::And => {