Skip to content

Commit

Permalink
add issue numbers to TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
phated committed May 23, 2023
1 parent 8ca4ec6 commit 60ba165
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion crates/nargo/src/ops/preprocess.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use noirc_driver::{CompiledProgram, ContractFunction};

use crate::artifacts::{contract::PreprocessedContractFunction, program::PreprocessedProgram};

// TODO: pull this from backend.
// TODO(#1388): pull this from backend.
const BACKEND_IDENTIFIER: &str = "acvm-backend-barretenberg";

pub fn preprocess_program<B: ProofSystemCompiler>(
Expand Down
4 changes: 2 additions & 2 deletions crates/nargo_cli/src/cli/compile_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use super::fs::{
};
use super::NargoConfig;

// TODO: pull this from backend.
// TODO(#1388): pull this from backend.
const BACKEND_IDENTIFIER: &str = "acvm-backend-barretenberg";

/// Compile the program and its secret execution trace into ACIR format
Expand Down Expand Up @@ -53,7 +53,7 @@ pub(crate) fn run<B: Backend>(
.compile_contracts(&args.compile_options)
.map_err(|_| CliError::CompilationError)?;

// TODO: I wonder if it is incorrect for nargo-core to know anything about contracts.
// TODO(#1389): I wonder if it is incorrect for nargo-core to know anything about contracts.
// As can be seen here, It seems like a leaky abstraction where ContractFunctions (essentially CompiledPrograms)
// are compiled via nargo-core and then the PreprocessedContract is constructed here.
// This is due to EACH function needing it's own CRS, PKey, and VKey from the backend.
Expand Down
6 changes: 3 additions & 3 deletions crates/nargo_cli/src/cli/fs/common_reference_string.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use acvm::{acir::circuit::Circuit, CommonReferenceString};

use super::{create_named_dir, write_to_file};

// TODO: pull this from backend.
// TODO(#1388): pull this from backend.
const BACKEND_IDENTIFIER: &str = "acvm-backend-barretenberg";
const TRANSCRIPT_NAME: &str = "common-reference-string.bin";

Expand All @@ -19,7 +19,7 @@ fn common_reference_string_location() -> PathBuf {
pub(crate) fn read_cached_common_reference_string() -> Vec<u8> {
let crs_path = common_reference_string_location();

// TODO: Implement checksum
// TODO(#1390): Implement checksum
match std::fs::read(crs_path) {
Ok(common_reference_string) => common_reference_string,
Err(_) => vec![],
Expand All @@ -35,7 +35,7 @@ pub(crate) fn update_common_reference_string<B: CommonReferenceString>(

let runtime = Builder::new_current_thread().enable_all().build().unwrap();

// TODO: Implement retries
// TODO(#1391): Implement retries
// If the read data is empty, we don't have a CRS and need to generate one
let fut = if common_reference_string.is_empty() {
backend.generate_common_reference_string(circuit)
Expand Down

0 comments on commit 60ba165

Please sign in to comment.