Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should be caching cargo dependencies #1303

Closed
1 task done
phated opened this issue May 5, 2023 · 2 comments · Fixed by #1421
Closed
1 task done

CI should be caching cargo dependencies #1303

phated opened this issue May 5, 2023 · 2 comments · Fixed by #1421
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented May 5, 2023

Problem

It seems that all cargo dependencies are being rebuilt on every CI run. These should be cached and rehydrated to significantly bring down the CI run times.

Proposed solution

In talking with @kobyhallx, he suggested that maybe this is due to not using "clean sources" within Nix. I believe he has experience with this and will dive in.

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@phated phated added the enhancement New feature or request label May 5, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 5, 2023
@phated phated moved this from 📋 Backlog to 🤔 Grooming in Noir May 5, 2023
@kobyhallx
Copy link
Contributor

Spent a few hours on this but src filtering does not seem to be an issue. In buildDepsOnly stage, the actual src is replaced with a dummy one to avoid source changes triggering re-builds.

@kobyhallx kobyhallx removed their assignment May 15, 2023
@phated phated self-assigned this May 26, 2023
@phated phated moved this from 🤔 Grooming to 🏗 In progress in Noir May 26, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir May 30, 2023
@phated
Copy link
Contributor Author

phated commented May 30, 2023

This dependency caching was working on my branch, but seems to still be building deps on master. I think this needs further investigation.

@phated phated reopened this May 30, 2023
@phated phated moved this from ✅ Done to 📋 Backlog in Noir Jun 29, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
4 participants