chore(nix): Fix dependency caching #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
commented
May 26, 2023
kevaundray
previously approved these changes
May 26, 2023
|
I should have switched this to a draft, as I'm still trying to look at the cache results |
phated
force-pushed
the
phated/nix-caching
branch
from
23a156a to
3139ca1
Compare
You mean the performance difference? |
Making sure I'm seeing the same results in CI as I saw locally. There's a subtle difference in how the nix store is restored in CI so I wanted to make sure this is working. |
|
Looks like it is working the same. Running |
kevaundray
approved these changes
May 30, 2023
kevaundray
added a commit
that referenced
this pull request
Jun 1, 2023
This reverts commit 9081ec9.
kevaundray
added a commit
that referenced
this pull request
Jun 1, 2023
This reverts commit 9081ec9.
kevaundray
added a commit
that referenced
this pull request
Jun 1, 2023
This reverts commit 9081ec9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #1303
Summary*
This updates the flake to enable better caching. When building the dependencies, we were injecting the
GIT_COMMITandGIT_DIRTYvariables, which made the dependencies rebuild from scratch on each commit. It also reworks the flake to have better delineation between native backend and wamer backend build targets (this will avoid needing the bb.wasm file during checks).Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.