Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve BACKEND_IDENTIFIER from backend (instead of hardcoding) #1388

Closed
phated opened this issue May 23, 2023 · 2 comments · Fixed by #3819
Closed

Retrieve BACKEND_IDENTIFIER from backend (instead of hardcoding) #1388

phated opened this issue May 23, 2023 · 2 comments · Fixed by #3819
Labels
discussion enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented May 23, 2023

Problem

Currently, we have cases in Nargo where we hardcode the BACKEND_IDENTIFIER as acvm-backend-barretenberg; however, this doesn't work with alternative backends.

Happy Case

Backends should provide an identifier via a function. This could also possibly include their version or other information, such as field, features, etc.

Alternatives Considered

No response

Additional Context

Work has begun in noir-lang/acvm#196 and noir-lang/acvm-backend-barretenberg#189

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@phated phated added the enhancement New feature or request label May 23, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 23, 2023
@phated phated mentioned this issue May 23, 2023
Merged
6 tasks
@Savio-Sou
Copy link
Collaborator

Unsure if this is still relevant with the latest nargo backend works.

Happy to hear thoughts if any, cc @TomAFrench @kevaundray. Might close this as stale otherwise.

@TomAFrench
Copy link
Member

Yes, this is still relevant as artifacts are tailored for a particular backend.

@Savio-Sou Savio-Sou changed the title Backend identifier constants should be provided via backend instead Generalize BACKEND_IDENTIFIER and retrieve that from backend (instead of hardcoding) Nov 2, 2023
@Savio-Sou Savio-Sou changed the title Generalize BACKEND_IDENTIFIER and retrieve that from backend (instead of hardcoding) Retrieve BACKEND_IDENTIFIER from backend (instead of hardcoding) Nov 2, 2023
@kevaundray kevaundray mentioned this issue Dec 16, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2023
@kevaundray @TomAFrench
chore!: Remove backend field from artifacts (#3819)
fa1cf5f 
# Description

In `kw/remove-partial-backend-code` we removed the opcodes supported
feature, which means that artifacts are no longer compiled based on a
backends feature set.


Closes #1388 

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: Remove backend field from artifacts noir-lang/noir
4 participants
@phated @TomAFrench @kevaundray @Savio-Sou