Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): Avoid storing Context until recompiles are possible #1891

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Jul 7, 2023

Description

Problem*

Resolves

Summary*

Currently, the compiler doesn't know how to recompile code. Instead if just returns immediately. By storing a context on the LSP state, no diagnostics would be sent because the codelens handler runs first.

We need to create a new Context on each message until we can make the compiler recompile files.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@phated phated enabled auto-merge July 7, 2023 17:38
@phated phated added this pull request to the merge queue Jul 7, 2023
Merged via the queue into master with commit fb5f20b Jul 7, 2023
@phated phated deleted the phated/avoid-storing-context branch July 7, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants