Enable using complex type inputs on dynamic slice intrinsics

[vezenovm]

Problem

We can appropriately use a dynamic slice intrinsic on a nested slice whose element types are primitive types, but we should be able to also use dynamic slice intrinsics on a nested slice whose element types are also complex types such as another nested slice.

Happy Case

If I have this nested slice:

struct FooParent {
    parent_arr: [Field; 3],
    foos: [Foo],
}

struct Bar {
    inner: [Field; 3],
}

struct Foo {
    a: Field,
    b: [Field],
    bar: Bar,
}

    let q = x.push_back(foo_four);
    let foo_parent_one = FooParent { parent_arr: [0, 1, 2], foos: x };
    let foo_parent_two = FooParent { parent_arr: [3, 4, 5], foos: q };
    let mut foo_parents = [foo_parent_one];
    foo_parents = foo_parents.push_back(foo_parent_two);

I should be able to do:

    assert(foo_parents[y - 2].foos.len() == 5);
    foo_parents[y - 2].foos = foo_parents[y - 2].foos.push_back(foo_four);
    assert(foo_parents[y - 2].foos.len() == 6);

the same way I can do:

    foo_parents[y - 2].foos[y - 1].b = foo_parents[y - 2].foos[y - 1].b.push_back(500);
    assert(foo_parents[y - 2].foos[y - 1].b.len() == 7);
    assert(foo_parents[y - 2].foos[y - 1].b[6] == 500);

where the nested slice simply has primitive element types.

Alternatives Considered

N/A

Additional Context

Nested dynamic slices were made possible by this pass (#3258). There is a chance that something is simply off in this pass rather than the ACIR gen.

After some investigation it does look like the fill internal slices pass is working as expected but this is still important to note in case I missed something.

Would you like to submit a PR for this Issue?

No

Support Needs

No response