Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide implementation for ECADD and ECDOUBLE #3983

Closed
guipublic opened this issue Jan 8, 2024 · 1 comment
Closed

Provide implementation for ECADD and ECDOUBLE #3983

guipublic opened this issue Jan 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

Problem

PR AztecProtocol/aztec-packages#3878 partially solves issue #3958, by introducing the new ECADD and ECDOUBLE opcodes both in Noir and BB.
However they are not implemented and using them will result in errors both in Noir and BB.

Happy Case

In order to finalise #3858, we still need to:

  • Add ACVM solvers for ECADD and ECDOUBLE
  • Update ACIR documentation
  • Generate circuits for ECADD and ECDOUBLE in BB/dsl, probably using cycle_group class
  • Add unit test in BB/DSL for these new opcodes
  • Add integration test in Noir demonstrating the use of the opcodes
  • Check Brillig behaviour when using the opcodes in unconstrained function (not sure if anything needs to be done, but at least check it works).

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@guipublic guipublic added the enhancement New feature or request label Jan 8, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 8, 2024
@kevaundray
Copy link
Contributor

Related to #3958

@guipublic guipublic mentioned this issue Jan 12, 2024
Merged
kevaundray pushed a commit to AztecProtocol/aztec-packages that referenced this issue Jan 25, 2024
@guipublic
feat: Implement Embedded EC add and double opcodes (#3982)
ccb7bff 
This PR resolves the following points from the issue
noir-lang/noir#3983:

- Add ACVM solvers for ECADD and ECDOUBLE
- Generate circuits for ECADD and ECDOUBLE in BB/dsl
- Add unit test in BB/DSL for these new opcodes
- Add integration test in Noir demonstrating the use of the opcodes
AztecBot pushed a commit that referenced this issue Jan 25, 2024
@guipublic @AztecBot
feat: Implement Embedded EC add and double opcodes (#3982)
9debf5c 
This PR resolves the following points from the issue
#3983:

- Add ACVM solvers for ECADD and ECDOUBLE
- Generate circuits for ECADD and ECDOUBLE in BB/dsl
- Add unit test in BB/DSL for these new opcodes
- Add integration test in Noir demonstrating the use of the opcodes
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Jan 26, 2024
@guipublic @AztecBot
feat: Implement Embedded EC add and double opcodes (#3982)
f18f311 
This PR resolves the following points from the issue
noir-lang/noir#3983:

- Add ACVM solvers for ECADD and ECDOUBLE
- Generate circuits for ECADD and ECDOUBLE in BB/dsl
- Add unit test in BB/DSL for these new opcodes
- Add integration test in Noir demonstrating the use of the opcodes
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 24, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@guipublic
feat: Implement Embedded EC add and double opcodes (AztecProtocol#3982)
da88424 
This PR resolves the following points from the issue
noir-lang/noir#3983:

- Add ACVM solvers for ECADD and ECDOUBLE
- Generate circuits for ECADD and ECDOUBLE in BB/dsl
- Add unit test in BB/DSL for these new opcodes
- Add integration test in Noir demonstrating the use of the opcodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TomAFrench @kevaundray @guipublic