Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document updated verify_proof #4139

Closed
Savio-Sou opened this issue Jan 23, 2024 · 0 comments · Fixed by #4187
Closed

Document updated verify_proof #4139

Savio-Sou opened this issue Jan 23, 2024 · 0 comments · Fixed by #4187
Assignees
@vezenovm
Labels
documentation Improvements or additions to documentation
Milestone
0.23

Comments

@Savio-Sou
Copy link
Collaborator

Update documentations of verify_proof, which was updated in #3955 (more precisely AztecProtocol/aztec-packages#3744).

Corresponding pages in docs:

cc @noir-lang/developerrelations FYI
@Savio-Sou Savio-Sou added the documentation Improvements or additions to documentation label Jan 23, 2024
@Savio-Sou Savio-Sou added this to the 0.23 milestone Jan 23, 2024
@Savio-Sou Savio-Sou added this to Noir Jan 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 23, 2024
This was referenced Jan 25, 2024
Closed
Closed
Merged
@vezenovm vezenovm mentioned this issue Jan 29, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 30, 2024
@signorecello @catmcgee
chore(docs): updating docs to match new recursion interfacee (#4187)
f4de6ee 
# Description

This PR documents the new recursion interface.

## Problem\*

Resolves #4139 
Resolves AztecProtocol/dev-rel#148

## Summary\*

- Removes the usage of `aggregation object` while retaining the mention
that recursive proofs are actually aggregation of proofs
- Removes the mention to add the size of public inputs to the proof, as
they are now separate
- Removes some leftover explainer in the `verify_proof` reference

## Additional Context

`noir-examples` is actually not working with this new interface, as I'm
blocked by a weird issue where proofs give me my dear friend
`unreachable`

Will debug that next week with @TomAFrench but I think we're good to
push the docs for now.

---------

Co-authored-by: Cat McGee <helloworld@mcgee.cat>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 30, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 1, 2024
@vezenovm @signorecello @catmcgee
chore(docs): Updates following is_recursive flag removal (#4199)
96a74bb 
# Description

## Problem\*

Followup to #4187 for resolving
#4139

## Summary\*

We no longer need to distinguish between `generateIntermediateProof` and
`generateFinalProof`. This will go into effect once
AztecProtocol/aztec-packages#4221 is merged and
released.

## Additional Context

## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: José Pedro Sousa <outgoing@zpedro.dev>
Co-authored-by: Cat McGee <helloworld@mcgee.cat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vezenovm vezenovm

Labels
documentation Improvements or additions to documentation
Projects
Noir
Archived in project
Milestone
0.23
Development

Successfully merging a pull request may close this issue.

chore(docs): updating docs to match new recursion interfacee noir-lang/noir
2 participants
@vezenovm @Savio-Sou