-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up misplaced items in stdlib #4845
Comments
It's also worth discussing if we want the hashers like |
Yeah, I was thinking along the same lines when writing this issue. I'm very much in favour of splitting a lot of these files out and using reexports liberally. I'd generally say that any trait in the stdlib should be in its own file due to the amount of boilerplate trait implementations for the primitive types it'll include, e.g. |
Worth considering implementing #4860 around the same time. |
# Description ## Problem\* Part of #4845 ## Summary\* This PR splits the `ops` module into `arith` and `bit` submodules similarly to the Rust stdlib. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
It seems like a fair number of function have been placed a bit haphazardly, e.g.
grumpkin_scalar_mul.nr
vsscalar_mul.nr
, why do we have this duplication? It's aztec code leaking into stdlib by the look of the serialization logic.We should do a pass of placing things where they should be to address these and similar issues. We can make this change non-breaking by adding reexports such as
The text was updated successfully, but these errors were encountered: