Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of format strings to the comptime interpreter #5482

Closed
Tracked by #4594
jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5596
Closed
Tracked by #4594

Add handling of format strings to the comptime interpreter #5482

jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5596
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 10, 2024

Problem

The comptime interpreter can't represent format string values currently and will error when they are used.

Happy Case

We add support for format string objects to the interpreter, or at least convert them into strings automatically.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Jul 10, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 24, 2024
# Description

## Problem\*

Resolves #5482

## Summary\*

Implements format strings in the interpreter.

These are a bit weird since we immediately interpolate them and thus
have no need to actually distinguish them from regular strings. They are
also lowered into runtime code as normal strings.

## Additional Context

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Michael J Klein <michaeljklein@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant