Switch Acir function Ids from raw integers to a struct type #5700
Labels
Comments
vezenovm
added
enhancement
5 tasks
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 19, 2024
# Description ## Problem\* Resolves #5700 ## Summary\* This PR includes an `AcirFunctionId` struct in place of raw integer identifier in the `Call` opcode to facilitate type safety. ## Additional Context - The `AcirFunctionId` struct is transparent for compatibility with serialization. ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
In our
Callopcode we have a raw integer type representing the Id of the function we want to call. We should avoid a raw integer type for an identifier.Happy Case
This should be wrapped in a struct type like
AcirFunctionId. The type should also be transparent as to not affect serialization.Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
None
Blocker Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: