Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP should suggest private items in auto-import #5879

Closed
asterite opened this issue Sep 2, 2024 · 0 comments · Fixed by #5923
Closed

LSP should suggest private items in auto-import #5879

asterite opened this issue Sep 2, 2024 · 0 comments · Fixed by #5923
Assignees
Labels
bug Something isn't working

Comments

@asterite
Copy link
Collaborator

asterite commented Sep 2, 2024

Aim

Private items are never suggested in LSP auto-import completions, but they should if they are visible from a sub-module.

Expected Behavior

In this code:

mod foo {
    fn qux() {
      b>|<
    }
}

fn bar() {}

fn main() {}

bar should be suggested.

Bug

Private items aren't suggested. (bar isn't suggested in the code snippet above)

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@asterite asterite added the bug Something isn't working label Sep 2, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 2, 2024
@asterite asterite self-assigned this Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 4, 2024
# Description

## Problem

Resolves #5879

## Summary

Uses the existing visibility check instead of just considering private
items to never be visible.

## Additional Context

None.

## Documentation

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant