Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether negative integer literals are out of range for their types #6247

Open
michaeljklein opened this issue Oct 8, 2024 · 1 comment
Open

Check whether negative integer literals are out of range for their types #6247

michaeljklein opened this issue Oct 8, 2024 · 1 comment
Assignees
@michaeljklein
Labels
enhancement New feature or request

Comments

@michaeljklein
Copy link
Contributor

Problem

The following test checks that a literal -1 is out of range for u8, and currently fails:

#[test]
fn cast_negative_one_to_u8_size_checks() {
    let src = r#"
        fn main() {
            assert((-1) as u8 != 0);
        }
    "#;
    let errors = get_program_errors(src);
    assert!(!errors.is_empty());
}

Happy Case

Reject negative literals outside of their type's range

  • Ensure that -1 as a u8 fails with an error
  • Ensure that using i8, i16, .. negative literals outside of their type's range fails with an error

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@michaeljklein michaeljklein added the enhancement New feature or request label Oct 8, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 8, 2024
@michaeljklein
Copy link
Contributor Author

Once #6137 is merged and this is fixed, #6219 will be addressed.

Noting that (0 - 1) as u8 is wontfix

@michaeljklein michaeljklein mentioned this issue Oct 9, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 9, 2024
@michaeljklein @TomAFrench
@vezenovm @jfecher
feat!: kind size checks (#6137)
6e40f62 
# Description

## Problem\*

* Need to check that type constants fit into their `Kind`'s
* The sizes of results from `op.function` and `evaluate_to_u32` are
unchecked

## Summary\*

Split out from #6094
- Some parts only work with its additional kind information
- Several follow up issues, including:
  * #6247
  * #6245
  * #6238

## Additional Context

TODO:
- [x] Add this test and/or similar execution tests unless we already
have a similar one (sanity-check that global `Field` arithmetic works
past `u32::MAX`)

```noir
// 2^32 + 1
global A: Field = 4294967297;
global B: Field = 4294967297;
global C: Field = A + B;

fn main() {
    // 2 * (2^32 + 1)
    assert(C == 8589934594);

    let mut leading_zeroes = 0;
    let mut stop = false;
    let bits: [u1; 64] = C.to_be_bits();
    for i in 0..64 {
        if (bits[i] == 0) & !stop {
            leading_zeroes += 1;
        } else {
            stop = true;
        }
    }
    let size = 64 - leading_zeroes;

    // 8589934594 has 34 bits
    assert(size == 34);
}
```

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
Co-authored-by: jfecher <jake@aztecprotocol.com>
@michaeljklein michaeljklein self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeljklein michaeljklein

Labels
enhancement New feature or request
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaeljklein