feat: update Prover.toml for merkle_insert and simple_shield with UP #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
approved these changes
Apr 7, 2023
vezenovm
changed the title
phated
added a commit
that referenced
this pull request
Apr 21, 2023
) * feat(build): Nix flake to build with * use debug ultra branch for backend, and temporary simple XOR/AND test added to nargo test_data * ignore result * Update deps * Avoid reading build data if we already have it * Update values for UP * Align flake with aztec_backend * update lockfile * skip simple_shield until it is updated * Update nix version with our workflow * Build with Nix in CI * Update backend deps * Simplify the nix file * chore(nargo)!: Update the codegen command to use vk, which requires circuit_name arg * chore!: Update Prover.toml for merkle_insert and simple_shield with UP (#1123) * re-enable simple_shield * use CARGO_MANIFEST_DIR to locate data for integration testing * clippy * patch for bb-sys * patch for bb * Add build workaround to wasm crate * clippy * Remove buggy clippy lint * cleanup flake * Rough guidelines for working on Noir with nix * chore: Cleanup UltraPlonk Debugging (#1130) cleanup debugging code from UP * update 8_integration main func * update to newer bb * update aztec_backend * update acvm to 0.9.0 * Reference temp commit on aztec_backend * fix some issues with the acvm 0.9 upgrade * temp lock to cody bb branch * chore: fix up merge issues * update for contract changes * update to appropriate refs * working on direnv * Update nix and direnv stuff * Update building documentation * Stop ignoring vscode dir and recommend extensions and settings * cspell * aztec_backend refs * nix lockfile * Simplify and rename workflow * docs cleanup * code review * Update crates/nargo_cli/tests/prove_and_verify.rs * Update crates/nargo_cli/tests/prove_and_verify.rs Co-authored-by: kevaundray <kevtheappdev@gmail.com> * Update cspell.json * Update README.md * Update cspell.json * update bb-sys for linux env fixes * add issue numbers to TODOs * Update transcript comment --------- Co-authored-by: Koby <koby@aztecprotocol.com> Co-authored-by: Maxim Vezenov <mvezenov@gmail.com> Co-authored-by: Tom French <tom@tomfren.ch> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
This PR updates the Prover.toml for
simple_shieldandmerkle_insertascheck_membershipnow uses pedersen plookup for compression now that we are integrating with UP.When running this PR with barretenberg master or the commit tagged here https://github.com/noir-lang/barretenberg-sys#dependencies
6_arrayfails with a seg fault. So does8_integration.Running this PR with barretenberg here: AztecProtocol/barretenberg#332, resolves this issue but still has an unresolved memory access. While testing locally
simple_shield,scalar_mul, andschnorrare returning invalid memory reference errors although they do not occur when the tests are run individually.Summary of changes
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context