Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nargo): restore nargo codegen-verifier functionality #1185

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Apr 19, 2023

Related issue(s)

Resolves #

Description

Summary of changes

Looks like we got a bit ahead of ourselves and started using eth_contract_from_vk against a commit of aztec_backend where that isn't implemented yet. If you run nargo codegen-verifier on v0.4.0 you get

$ nargo codegen-verifier
The application panicked (crashed).
Message:  not yet implemented: use `eth_contract_from_cs` for now
Location: /home/tom/.cargo/git/checkouts/aztec_backend-a697fb631cbad807/2617835/barretenberg_static_lib/src/acvm_interop/smart_contract.rs:10

This is a bug. Consider opening an issue at https://github.com/noir-lang/noir/issues/new?labels=bug&template=bug_report.yml

This PR reverts to eth_contract_from_cs and adds an integration test that if you run codegen-verifier the command succeeds and you get some file created.

I haven't made any change to nargo::ops::codegen_verifier as that's backend agnostic and I don't want to make a breaking change to fix this.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray added this pull request to the merge queue Apr 19, 2023
Merged via the queue into master with commit 528a2a4 Apr 20, 2023
@kevaundray kevaundray deleted the fix-codegen-verifier branch April 20, 2023 00:05
TomAFrench added a commit that referenced this pull request Apr 24, 2023
* master:
  chore: update flake version to match current release (#1204)
  feat!: Switch to aztec_backend that uses upstream BB & UltraPlonk (#1114)
  chore(ssa refactor): Add Context structs and start ssa gen pass (#1196)
  chore(ssa): Replace JmpIf with BrIf (#1193)
  chore(noir): Release 0.4.1 (#1164)
  chore(ssa refactor): Add DenseMap and SparseMap types (#1184)
  feat: bump noir-source-resolver version (#1182)
  chore(deps): bump h2 from 0.3.16 to 0.3.18 (#1186)
  fix(nargo): restore `nargo codegen-verifier` functionality (#1185)
  chore: simplify setup code in `noir_integration` test (#1180)
  feat: Add Poseidon-BN254 hash functions (#1176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants