Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssa refactor): Handle function parameters #1203

Merged
merged 9 commits into from
Apr 24, 2023
Merged

chore(ssa refactor): Handle function parameters #1203

merged 9 commits into from
Apr 24, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Apr 21, 2023

Related issue(s)

Resolves #

Description

Summary of changes

  • ssa ir/builder:
    • Adds functionality to add block and function parameters in FunctionBuilder, DataFlowGraph
    • Adds missing Return block terminator to end a function
    • Adds Reference and Function types
  • ssa-gen:
    • Adds correct parameter handling with tuple flattening to FunctionContext, ssa-gen pass
    • Restructures Value into Tree<Value> so that we can have helper functions like map_type to map Tree<T> to Tree<U>. This is often useful for mapping types Tree<Type> to values Tree<Value> or vice-versa.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

@jfecher jfecher added this pull request to the merge queue Apr 24, 2023
Merged via the queue into master with commit cca45a4 Apr 24, 2023
@jfecher jfecher deleted the jf/ssa branch April 24, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants