chore: Emit an error for the 'return' expression #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My guess is that |
kevaundray
changed the title
jfecher
reviewed
Apr 25, 2023
|
@jfecher A 'return' statement fails with an additional error when not followed by a semicolon, but I guess it's not an issue to allow that. |
|
@pczarn you should be able to remove the semicolon error by adding an appropriate case for Return in |
6 tasks
|
@jfecher Fixed according to your advice. |
joss-aztec
reviewed
May 9, 2023
| Statement::Return { expr, semi: false } => { | ||
| if !last_statement_in_block && semi.is_none() { | ||
| let reason = "Expected a ; separating these two statements".to_string(); | ||
| emit_error(ParserError::with_reason(reason, span)); |
There was a problem hiding this comment.
As of #1286, ParserError::with_reason takes an enum (hence the failing tests). You can add a variant in parser/errors.rs.
6 tasks
|
Closing as #1330 was merged |
auto-merge was automatically disabled
July 13, 2023 12:52
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1190
Description
Emit the
Early 'return' is unsupportedmessage for the 'return' expressionDependency additions / changes
N/A
Test additions / changes
Added
return_validationChecklist
cargo fmtwith default settings.Documentation needs
Additional context
N/A