chore!(noir): deprecation warning for constrain #1275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Propagate distinction between assert/constrain into hir resolution - Also replace stdlib usages of constrain with assert - `cargo new` uses assert in template
1 task
|
Blocked by: #1251 |
|
The PR is failing due to the integration examples using constrain. I have re-assigned #1251 to you, lets open up a separate PR which changes the examples and stdlib to using assert resolving 1251 |
kevaundray
changed the title
|
Closed in favour of #1286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1228
Description
Summary of changes
Emit a depreciation warning when encountering the
constrainkeyword, plus a tip on how to resolve. It was convenient to emit this warning during HIR resolution, hence the distinction between assert/constrain was propagated beyond the parser.Stdlib usages of
constrainare now also replaced withassert. Thenargo newtemplate now also usesassertinstead of constrain.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context