-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: to-bits and to-radix for > 128 bits #1312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with replacing u128 with field elements for intrinsic arguments, but I am not sure your changes in the overflow check is correct. Could you provide a proof of correctness?
I reverted to the old overflow check based on the comments. There are also a couple of other issues in the
I guess I can fix these in a follow-up PR once I know what the right behaviour should be. |
* fix: to-bits and to-radix for > 128 bits * revert: use earlier overflow check that ensures unicity
* master: (66 commits) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279) feat: enable to_radix for any field element (#1343) chore(ssa refactor): Simplify inlining pass and fix inlining failure (#1337) chore!: Update to acvm 0.11.0 (#1322) feat: Add ECDSA secp256k1 builtin test (#1294) chore: add support for encoding/decoding inputs from JSON (#1325) feat: Issue an error when attempting to use a `return` expression (#1330) chore(ssa refactor): Fix inlining bug (#1335) fix: to-bits and to-radix for > 128 bits (#1312) chore(parser): Parser error optimisation (#1292) chore(ssa refactor): Implement function inlining (#1293) chore: fix installation link in readme (#1326) chore: fix installation link in readme (#1326) feat(stdlib): Add keccak (#1249) fix: Parsing nested generics (#1319) chore(ssa refactor): Document some SSA-gen functions (#1321) fix: Assigning to tuple fields (#1318) ...
Related issue(s)
Resolves #1311
See #1109 (comment)
Description
Summary of changes
u128
before converting to bits or bytesAllowto_radix_base
to work for elements close to the modulusDependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Documentation needs
Additional context
BEGIN_COMMIT_OVERRIDE
fix(stdlib): support use of
to_bits
andto_radix
for values >128 bits (#1312)END_COMMIT_OVERRIDE