Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update noir for acir simplify feature #1333

Closed
wants to merge 9 commits into from

Conversation

guipublic
Copy link
Contributor

Description

Summary of changes

This PR updates noir with the simplify PR in ACVM.
It provides an empty simplifier, which does nothing, to ACVM for compiling the circuit
The simplification is not activated because I want to be able to properly test it once noir is updated with the corresponding ACVM. However, because the compile function now takes the simplifier, noir needs to be updated, which is what this PR is for.
Error handling as been added to acir_gen because the simplification can find out that some arithmetic gates are not satisfied.

Dependency additions / changes

The PR does not update noir ACVM version, but it does require a new version. Until then, the PR will fail.

Test additions / changes

The feature is not enabled.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • [] I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

@sirasistant
Copy link
Contributor

I think these changes might need to be integrated into the PR for ACVM 0.12 #1339

@TomAFrench
Copy link
Member

Heads up that this clashes with #1394 as we're not going to be calling acvm::compiler::compile within noirc_evaluator.

@TomAFrench
Copy link
Member

We can probably close this as we're not adding new features to the old SSA.

@TomAFrench TomAFrench closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants