-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Recursive verification #1379
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1154
Description
This adds a foreign function to enable recursive verification of proofs.
Summary of changes
A new std lib method was added:
Although this function signature is not final as I would like to remove the key hash field and have it be handled by the compiler. The key hash will have to be specific to a backend and we cannot rely on the compiler to generate the key hash without backend interop.
Include a way to generate inner recursive proofs with nargo. The barretenberg backend requries a different hash type for recursive proofs (it using pedersen-blake3 for efficiency), however, the Noir requries a keccak based prover in order to be compatible with the Solidity verifier. This is why a new RecursiveProver type was added to the DSL package.
Dependency additions / changes
ACVM: noir-lang/acvm#291
acvm-backend-barretenberg: noir-lang/acvm-backend-barretenberg#146
Test additions / changes
There is a new
recursion
test that calls the newverify_proof
foreign function. The recursive data comes from thexor
test.Checklist
cargo fmt
with default settings.Documentation needs
Additional context