Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Acvm 0.13.0 branch #1465

Merged
merged 3 commits into from
Jun 1, 2023
Merged

chore: Update Acvm 0.13.0 branch #1465

merged 3 commits into from
Jun 1, 2023

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented May 31, 2023

Description

Problem*

PR #1393 is blocked by the below issue:

error: builder for '/nix/store/ssvx74iijl8mfw4s64083a0qgv1lr8vj-noir-native-clippy-0.6.0.drv' failed with exit code 101;
       last 10 log lines:
       > error[E0432]: unresolved import `acvm_backend_barretenberg`
       >  --> crates/nargo_cli/src/backends.rs:1:16
       >   |
       > 1 | pub(crate) use acvm_backend_barretenberg::Barretenberg as ConcreteBackend;
       >   |                ^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `acvm_backend_barretenberg`

This PR updates the reference to the acvm-backend-barretenberg repo with the cargo manifest in this PR: noir-lang/acvm-backend-barretenberg#215

Summary*

This PR sets out to

Example

Before:


After:


Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm marked this pull request as ready for review May 31, 2023 17:36
@kevaundray kevaundray merged commit e0ecfb1 into acvm-0.13.0 Jun 1, 2023
@kevaundray kevaundray deleted the acvm-0.13.0-dbg branch June 1, 2023 10:20
vezenovm added a commit that referenced this pull request Jun 1, 2023
* chore!: Update to ACVM 0.12.0

* feat: adapted to heterogeneous bb calls

* chore: update cargo tomls

* test: re enabled sort test

* fix: improve variable resolution

* feat: use dummy constructor for bb call

* updates for latest

* feat!: Move WitnessMap type into ACVM to avoid leaking BTreeMap type

* feat(nargo): Consume CommonReferenceString functions & manage caching (#1348)

* switch to published acvm and backend

* fix compilation issue

* chore: Remove usage of `acvm::default_is_opcode_supported` (#1366)

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Tom French <tom@tomfren.ch>

* add issue numbers to TODOs

* chore: update to ACVM 0.13.0

* chore: fix broken import

* chore: bump commit

* chore: Update Acvm 0.13.0 branch  (#1465)

have acvm-backend-bberg patch reference new branch with additional crate-type

* Update Cargo.toml

* Update Cargo.toml

* update flake.lock

* feat!: var message size for keccak in stdlib (#1481)

* Var message size for keccak in stdlib

* fix the build:
remove aes blackbox
add domain separator for pedersen

* pedersen with domain separator

* chore: update pedersen test case for domain separator (#1482)

pedersen with domain separator

* chore: add pedersen hash with domain separator in stdlib (#1483)

* pedersen with domain separator

* separator for pedersen

* update to acvm 0.13.0 and new acvm-backend-bberg

* update cargo lock

* update MockBackend in sort test

* update merkle_insert and simple_shield for updated pedersen in bberg

* try ubuntu-large

* remove patch and update to acvm-backend-bberg 0.3.0

* cargo.lock

---------

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: sirasistant <sirasistant@gmail.com>
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants