Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make use of type information when serialising inputs #1655

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves #1324

Summary*

This PR exposes ABI type information when converting the input map to toml. This allows types which are represented by a single field can be serialized to a more specific format based on its type, e.g. booleans get converted to true/false instead of 0x00....01/0x00....00.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested review from phated and jfecher June 16, 2023 04:07
@TomAFrench TomAFrench requested a review from jfecher July 4, 2023 04:49
@TomAFrench TomAFrench added this pull request to the merge queue Jul 4, 2023
Merged via the queue into master with commit 310368d Jul 4, 2023
@TomAFrench TomAFrench deleted the type-aware-toml-types branch July 4, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more readable serialisation of InputValues representing boolean values.
2 participants