Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add abstraction layer around ACIR gen of quotient directives #1900

Merged
merged 8 commits into from
Jul 10, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

The bigger issue here is the fact that we are liberally creating witnesses out of thin air. An abstraction over this like range_directive would help here

…hub.com:noir-lang/noir into kw/solve-quotient-before-using-it-in-constraint
@TomAFrench
Copy link
Member

An abstraction over this like range_directive would help here

I can add this in this PR if you're not working on this already.

@kevaundray
Copy link
Contributor Author

An abstraction over this like range_directive would help here

I can add this in this PR if you're not working on this already.

Sorry forgot to reply -- yeah this would be good, I have a few things in the backlog, so it would be quicker if you did it

@kevaundray
Copy link
Contributor Author

@TomAFrench do you want to add it here, or should we merge this and add it in a separate PR? (Either way is fine with me, my suggestion above would affect more than just the quotient directive I think, so we would need to rename the PR appropriately)

@TomAFrench TomAFrench changed the title chore: Solve the quotient and remainder before applying constraints. chore: Add abstraction layer around acir gen of quotient directives Jul 10, 2023
@TomAFrench
Copy link
Member

Easiest to do it here. Reordering the opcodes is only a substantive change in the context of #1729 so we can just make this PR be primarily about the new abstraction layer.

@TomAFrench TomAFrench marked this pull request as ready for review July 10, 2023 12:42
@TomAFrench
Copy link
Member

@kevaundray if you give an ok in the comments here, I can approve + merge.

@TomAFrench
Copy link
Member

Looks like we should add the range constraints into the helper as well.

@kevaundray
Copy link
Contributor Author

LGTM

TomAFrench
TomAFrench previously approved these changes Jul 10, 2023
@TomAFrench TomAFrench enabled auto-merge July 10, 2023 13:35
@TomAFrench TomAFrench changed the title chore: Add abstraction layer around acir gen of quotient directives chore: Add abstraction layer around ACIR gen of quotient directives Jul 10, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit db41fb8 Jul 10, 2023
@TomAFrench TomAFrench deleted the kw/solve-quotient-before-using-it-in-constraint branch July 10, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants