Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rebuild tests plus script to include secp256r1 change #1908

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: Rebuild tests plus script to include secp256r1 change #1908

merged 1 commit into from
Jul 10, 2023

Conversation

charlielye
Copy link
Contributor

@charlielye charlielye commented Jul 10, 2023 •
edited by kevaundray
Loading

Description

This is being rebuilt because the previous script did not include the addition of secp256r1 in acir

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@charlielye charlielye requested a review from kevaundray July 10, 2023 23:07
@kevaundray kevaundray enabled auto-merge July 10, 2023 23:10
@kevaundray kevaundray changed the title fix: Rebuild tests plus script. fix: Rebuild tests plus script to include secp256r1 change Jul 10, 2023
@kevaundray kevaundray added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit ca68666 Jul 10, 2023
@kevaundray kevaundray deleted the cl/rebuild_tests branch July 10, 2023 23:32
@kevaundray kevaundray mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlielye @kevaundray